pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer
Date Wed, 02 Jan 2019 08:54:34 GMT
sijie commented on a change in pull request #3273: Adding config auto.offset.reset to PulsarKafkaConsumer
URL: https://github.com/apache/pulsar/pull/3273#discussion_r244682644
 
 

 ##########
 File path: pulsar-client-kafka-compat/pulsar-client-kafka/src/main/java/org/apache/kafka/clients/consumer/PulsarKafkaConsumer.java
 ##########
 @@ -65,6 +66,7 @@
 
 @Slf4j
 public class PulsarKafkaConsumer<K, V> implements Consumer<K, V>, MessageListener<byte[]>
{
+	private static enum OffsetResetStrategy {EARLIEST, LATEST, NONE}
 
 Review comment:
   ```suggestion
        private static enum OffsetResetStrategy {EARLIEST, LATEST, NONE}
   ```
   
   wrong indent ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message