pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3271: remove function details from v3 function endpoints
Date Tue, 01 Jan 2019 02:02:07 GMT
sijie commented on a change in pull request #3271: remove function details from v3 function
endpoints
URL: https://github.com/apache/pulsar/pull/3271#discussion_r244626847
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/FunctionsBase.java
 ##########
 @@ -101,11 +100,10 @@ public void updateFunction(final @PathParam("tenant") String tenant,
                                final @FormDataParam("data") InputStream uploadedInputStream,
                                final @FormDataParam("data") FormDataContentDisposition fileDetail,
                                final @FormDataParam("url") String functionPkgUrl,
-                               final @FormDataParam("functionDetails") String functionDetailsJson,
 
 Review comment:
   if you removed this from base, does it break v1 and v2?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message