From commits-return-19707-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Dec 27 12:42:41 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id F272A180677 for ; Thu, 27 Dec 2018 12:42:40 +0100 (CET) Received: (qmail 80193 invoked by uid 500); 27 Dec 2018 11:42:40 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 80184 invoked by uid 99); 27 Dec 2018 11:42:40 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Dec 2018 11:42:40 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] maskit commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template Message-ID: <154591095957.7983.6947879972500573670.gitbox@gitbox.apache.org> Date: Thu, 27 Dec 2018 11:42:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit maskit commented on issue #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#issuecomment-450135707 > because not every code change requires documentation. Most of code changes don't require documentation, e.g. bug fixes, and tasks for a large features. > If a change is changing any item under "Does this pull request potentially affect one of the following parts", this change is most likely required to have related documentation change. Thanks for the clarification. I understand the policy and I'm fine with it. However, the questions in Documentation section might be confusing a little if that is the policy. > - Does this pull request introduce a new feature? (yes / no) > - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) These questions imply that you can say "yes, but it's not documented". There would be cases we accept as exceptions so it's a valid answer, but I'm not sure we should show such a option. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services