From commits-return-19629-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Dec 26 14:06:33 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 52EF4180677 for ; Wed, 26 Dec 2018 14:06:33 +0100 (CET) Received: (qmail 18092 invoked by uid 500); 26 Dec 2018 13:06:32 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 18083 invoked by uid 99); 26 Dec 2018 13:06:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Dec 2018 13:06:32 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] maskit commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template Message-ID: <154582959195.11903.9403327795255325804.gitbox@gitbox.apache.org> Date: Wed, 26 Dec 2018 13:06:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit maskit commented on a change in pull request #3252: [dev] PIP 27: Add checklist in github pull request template URL: https://github.com/apache/pulsar/pull/3252#discussion_r243993709 ########## File path: .github/PULL_REQUEST_TEMPLATE.md ########## @@ -1,12 +1,62 @@ +<-- +### Contribution Checklist + + - Name the pull request in the form "[component] Title of the pull request". Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`. + + - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. + + - Make sure that the change passes the CI checks. + + - Each pull request should address only one issue, not mix up code from multiple issues. + + - Each commit in the pull request has a meaningful commit message + + - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. Review comment: Why don't we use actual checkboxes? - [ ] abc - [ ] xyz ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services