From commits-return-18842-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Tue Dec 11 00:52:37 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 35BC1180648 for ; Tue, 11 Dec 2018 00:52:37 +0100 (CET) Received: (qmail 10760 invoked by uid 500); 10 Dec 2018 23:52:36 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 10751 invoked by uid 99); 10 Dec 2018 23:52:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Dec 2018 23:52:36 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #3158: improve avro schema deserialization by reusing binary decoder Message-ID: <154448595581.2943.11406990683287151376.gitbox@gitbox.apache.org> Date: Mon, 10 Dec 2018 23:52:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #3158: improve avro schema deserialization by reusing binary decoder URL: https://github.com/apache/pulsar/pull/3158#discussion_r240426990 ########## File path: pulsar-client-schema/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java ########## @@ -45,6 +47,9 @@ private BinaryEncoder encoder; private ByteArrayOutputStream byteArrayOutputStream; + public static final FastThreadLocal decoders = Review comment: `private` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services