From commits-return-18710-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Dec 6 21:21:51 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 91310180674 for ; Thu, 6 Dec 2018 21:21:50 +0100 (CET) Received: (qmail 55795 invoked by uid 500); 6 Dec 2018 20:21:49 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 55786 invoked by uid 99); 6 Dec 2018 20:21:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Dec 2018 20:21:49 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set Message-ID: <154412770913.31647.648481772931574275.gitbox@gitbox.apache.org> Date: Thu, 06 Dec 2018 20:21:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set URL: https://github.com/apache/pulsar/pull/3126#discussion_r239600291 ########## File path: site2/docs/cookbooks-partitioned.md ########## @@ -65,7 +65,7 @@ String topic = "persistent://my-tenant/my-cluster-my-namespace/my-topic"; PulsarClient client = PulsarClient.create(pulsarBrokerRootUrl); ProducerConfiguration config = new ProducerConfiguration(); -config.setMessageRouter(AlwaysTenRouter); +config.setMessageRouter(new AlwaysTenRouter()); Review comment: Ouch, this should have already been changed to the new preferred API : `client.newProducer().messageRouter(...).create()` Can you fix it in this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services