pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3263: Improve documentation for message routing mode
Date Mon, 31 Dec 2018 19:01:53 GMT
merlimat commented on a change in pull request #3263: Improve documentation for message routing
mode
URL: https://github.com/apache/pulsar/pull/3263#discussion_r244540052
 
 

 ##########
 File path: site2/docs/concepts-messaging.md
 ##########
 @@ -199,15 +199,32 @@ Partitioned topics need to be explicitly created via the [admin API](admin-api-o
 
 When publishing to partitioned topics, you must specify a *routing mode*. The routing mode
determines which partition---that is, which internal topic---each message should be published
to.
 
-There are three routing modes available by default:
+There are three {@inject: javadoc:MessageRoutingMode:/client/org/apache/pulsar/client/api/MessageRoutingMode}
available:
 
-Mode | Description | Ordering guarantee
-:----|:------------|:------------------
-Key hash | If a key property has been specified on the message, the partitioned producer
will hash the key and assign it to a particular partition. | Per-key-bucket ordering
-Single default partition | If no key is provided, each producer's message will be routed
to a dedicated partition, initially random selected | Per-producer ordering
-Round robin distribution | If no key is provided, all messages will be routed to different
partitions in round-robin fashion to achieve maximum throughput. | None
+Mode     | Description 
+:--------|:------------
+RoundRobinPartition | If no key is provided, the producer will publish messages across all
partitions in round-robin fashion to achieve maximum throughput. Please note that round-robin
is not done per individual message but rather it's set to the same boundary of batching delay,
to ensure batching is effective. While if a key is specified on the message, the partitioned
producer will hash the key and assign message to a particular partition. This is the default
mode. 
 
 Review comment:
   ```suggestion
    `RoundRobinPartition` | If no key is provided, the producer will publish messages across
all partitions in round-robin fashion to achieve maximum throughput. Please note that round-robin
is not done per individual message but rather it's set to the same boundary of batching delay,
to ensure batching is effective. While if a key is specified on the message, the partitioned
producer will hash the key and assign message to a particular partition. This is the default
mode. 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message