pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] erenavsarogullari commented on a change in pull request #3265: [flink-consumer-source] fix up streaming to be consistent with batch
Date Sat, 29 Dec 2018 19:57:37 GMT
erenavsarogullari commented on a change in pull request #3265:  [flink-consumer-source] fix
up streaming to be consistent with batch
URL: https://github.com/apache/pulsar/pull/3265#discussion_r244507174
 
 

 ##########
 File path: examples/flink-consumer-source/pom.xml
 ##########
 @@ -66,6 +66,18 @@
       <version>${flink.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>org.apache.flink</groupId>
+      <artifactId>flink-streaming-scala_${scala.binary.version}</artifactId>
+      <version>${flink.version}</version>
+    </dependency>
+
+    <dependency>
+      <groupId>org.apache.flink</groupId>
+      <artifactId>flink-table_${scala.binary.version}</artifactId>
 
 Review comment:
   flink-table_${scala.binary.version} looks redundant as well (defined as 2 times)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message