pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3228: Provide separate module with Pulsar v1 client API wrapper
Date Fri, 21 Dec 2018 20:45:11 GMT
merlimat commented on a change in pull request #3228: Provide separate module with Pulsar v1
client API wrapper
URL: https://github.com/apache/pulsar/pull/3228#discussion_r243688278

 File path: pulsar-client-1x-base/pulsar-client-2x-shaded/pom.xml
 @@ -0,0 +1,91 @@
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements.  See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership.  The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License.  You may obtain a copy of the License at
+      http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    KIND, either express or implied.  See the License for the
+    specific language governing permissions and limitations
+    under the License.
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <modelVersion>4.0.0</modelVersion>
+  <parent>
+    <groupId>org.apache.pulsar</groupId>
+    <artifactId>pulsar-client-1x-base</artifactId>
+    <version>2.3.0-SNAPSHOT</version>
+    <relativePath>..</relativePath>
+  </parent>
+  <artifactId>pulsar-client-2x-shaded</artifactId>
 Review comment:
   The problem I'm trying to solve here is that `pulsar-client-1x` is a wrapper over `pulsar-client`.
At the same time, we have some interfaces that need to be duplicated in `pulsar-client-1x`
(because the 2.x version will be different). 
   So, `pulsar-client-2x-shaded` is really `pulsar-client` but with just few interfaces renamed
(eg: `PulsarClient`, `Producer`, `Consumer` and `Reader`) to avoid conflicts with the 1.x
   So, although confusing, `pulsar-client-2x-shaded` is really the correct name and this module
is not meant for direct usage anyway.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message