pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #3228: Provide separate module with Pulsar v1 client API wrapper
Date Fri, 21 Dec 2018 19:07:41 GMT
jerrypeng commented on a change in pull request #3228: Provide separate module with Pulsar
v1 client API wrapper
URL: https://github.com/apache/pulsar/pull/3228#discussion_r243667192
 
 

 ##########
 File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/schema/DefaultSchemasTest.java
 ##########
 @@ -67,30 +61,6 @@ public void testReaderInstantiation() {
         Assert.assertNotNull(stringReaderBuilder);
     }
 
-    @Test
-    public void testStringSchema() throws Exception {
-        String testString = "hello world";
-        byte[] testBytes = testString.getBytes(StandardCharsets.UTF_8);
-        StringSchema stringSchema = new StringSchema();
-        Assert.assertTrue(stringSchema.decode(testBytes).equals(testString));
-        assertEquals(stringSchema.encode(testString), testBytes);
-
-        Message<String> msg1 = MessageBuilder.create(stringSchema)
 
 Review comment:
   lets just get rid of the MessageBuilder portion  of the test since since that is V1 API
 but we should keep the rest of the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message