pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3168: Refactor api commands
Date Thu, 20 Dec 2018 03:22:20 GMT
sijie commented on a change in pull request #3168: Refactor api commands
URL: https://github.com/apache/pulsar/pull/3168#discussion_r243146197
 
 

 ##########
 File path: pulsar-functions/worker/src/test/java/org/apache/pulsar/functions/worker/rest/api/v2/SinkApiV2ResourceTest.java
 ##########
 @@ -180,54 +182,69 @@ public void setup() throws Exception {
     // Register Functions
     //
 
-    @Test
-    public void testRegisterSinkMissingTenant() throws IOException {
-        testRegisterSinkMissingArguments(
-            null,
-            namespace,
-                sink,
-            mockedInputStream,
-            mockedFormData,
-            topicsToSerDeClassName,
-            className,
-            parallelism,
+    @Test(expectedExceptions = RestException.class, expectedExceptionsMessageRegExp = "Tenant
is not provided")
+    public void testRegisterSinkMissingTenant() {
+        try {
+            testRegisterSinkMissingArguments(
                 null,
-                "Tenant is not provided");
+                namespace,
+                    sink,
+                mockedInputStream,
+                mockedFormData,
+                topicsToSerDeClassName,
+                className,
+                parallelism,
+                    null
+            );
+        } catch (RestException re){
+            assertEquals(re.getResponse().getStatusInfo(), Response.Status.BAD_REQUEST);
+            throw re;
+        }
     }
 
-    @Test
-    public void testRegisterSinkMissingNamespace() throws IOException {
-        testRegisterSinkMissingArguments(
-            tenant,
-            null,
-                sink,
-            mockedInputStream,
-            mockedFormData,
-            topicsToSerDeClassName,
-            className,
-            parallelism,
+    @Test(expectedExceptions = RestException.class, expectedExceptionsMessageRegExp = "Namespace
is not provided")
+    public void testRegisterSinkMissingNamespace() {
+        try {
+            testRegisterSinkMissingArguments(
+                tenant,
                 null,
-                "Namespace is not provided");
+                    sink,
+                mockedInputStream,
+                mockedFormData,
+                topicsToSerDeClassName,
+                className,
+                parallelism,
+                    null
+            );
+        } catch (RestException re){
+            assertEquals(re.getResponse().getStatusInfo(), Response.Status.BAD_REQUEST);
+            throw re;
+        }
     }
 
-    @Test
-    public void testRegisterSinkMissingFunctionName() throws IOException {
-        testRegisterSinkMissingArguments(
-            tenant,
-            namespace,
-            null,
-            mockedInputStream,
-            mockedFormData,
-            topicsToSerDeClassName,
-            className,
-            parallelism,
+    @Test(expectedExceptions = RestException.class, expectedExceptionsMessageRegExp = "Sink
Name is not provided")
 
 Review comment:
   keep all assertions in one place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message