pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] erenavsarogullari commented on a change in pull request #3205: [pulsar-flink] Implements a batch program on Pulsar topic by writing Flink DataSet as Avro
Date Mon, 17 Dec 2018 20:02:33 GMT
erenavsarogullari commented on a change in pull request #3205: [pulsar-flink] Implements a
batch program on Pulsar topic by writing Flink DataSet as Avro
URL: https://github.com/apache/pulsar/pull/3205#discussion_r242290430
 
 

 ##########
 File path: examples/flink-consumer-source/src/main/scala/org/apache/flink/batch/connectors/pulsar/example/README.md
 ##########
 @@ -279,5 +279,67 @@ Please find sample output for above application as follows:
 
 ### Complete Example
 
-You can find a complete example [here](https://github.com/apache/incubator-pulsar/tree/master/pulsar-flink/src/test/scala/org/apache/flink/batch/connectors/pulsar/example/FlinkPulsarBatchJsonSinkScalaExample.scala).
+You can find a complete example [here](https://github.com/apache/pulsar/tree/master/examples/flink-consumer-source/src/main/scala/org/apache/flink/batch/connectors/pulsar/example/FlinkPulsarBatchJsonSinkScalaExample.scala).
 In this example, Flink DataSet is processed and written to Pulsar in Json format.
+
+
+# PulsarJsonOutputFormat
 
 Review comment:
   @ambition119 Firstly, thanks for the contribution.
   Following documentation needs to point `PulsarAvroOutputFormat` documentation.
   Also row: **289** and **304**.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message