pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage
Date Fri, 14 Dec 2018 19:46:27 GMT
david-streamlio commented on a change in pull request #2865: Refactored JCloud Tiered Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r241869883
 
 

 ##########
 File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/suites/PulsarTieredStorageTestSuite.java
 ##########
 @@ -58,8 +58,8 @@ public void setupCluster() throws Exception {
             brokerContainer.withEnv("managedLedgerMaxEntriesPerLedger", String.valueOf(ENTRIES_PER_LEDGER));
             brokerContainer.withEnv("managedLedgerMinLedgerRolloverTimeMinutes", "0");
             brokerContainer.withEnv("managedLedgerOffloadDriver", "s3");
-            brokerContainer.withEnv("bucket", "pulsar-integtest");
-            brokerContainer.withEnv("endpoint", "http://" + S3Container.NAME + ":9090");
+            brokerContainer.withEnv("s3ManagedLedgerOffloadBucket", "pulsar-integtest");
 
 Review comment:
   This brings up two questions:
   
   1) Should I just create a second class for the BC tests, e.g. PulsarTieredStorageBCTestSuite?
   2) How are the following properties being propagated to the JCloud provider?  I didn't
see any place in the code (old or new) that does this, which has me concerned that I might
have missed something.
   
    brokerContainer.withEnv("managedLedgerMaxEntriesPerLedger", String.valueOf(ENTRIES_PER_LEDGER));
    brokerContainer.withEnv("managedLedgerMinLedgerRolloverTimeMinutes", "0");

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message