pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3184: remove pulsar-client-schema (WIP)
Date Fri, 14 Dec 2018 05:42:02 GMT
merlimat commented on a change in pull request #3184: remove pulsar-client-schema (WIP)
URL: https://github.com/apache/pulsar/pull/3184#discussion_r241648748
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctionWorker.java
 ##########
 @@ -57,22 +56,22 @@ void processArguments() throws Exception {
         abstract void runCmd() throws Exception;
     }
 
-    @Parameters(commandDescription = "dump all functions stats")
-    class FunctionsStats extends BaseCommand {
-
-        @Parameter(names = { "-i", "--indent" }, description = "Indent JSON output", required
= false)
-        boolean indent = false;
-
-        @Override
-        void runCmd() throws Exception {
-            String json = JsonFormat.printer().print(admin.worker().getFunctionsStats());
-            GsonBuilder gsonBuilder = new GsonBuilder();
-            if (indent) {
-                gsonBuilder.setPrettyPrinting();
-            }
-            System.out.println(gsonBuilder.create().toJson(new JsonParser().parse(json)));
-        }
-    }
+//    @Parameters(commandDescription = "dump all functions stats")
 
 Review comment:
   is this related?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message