pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #3192: Upgrade caffiene dependency in pom.xml
Date Fri, 14 Dec 2018 01:21:05 GMT
sijie commented on a change in pull request #3192: Upgrade caffiene dependency in pom.xml
URL: https://github.com/apache/pulsar/pull/3192#discussion_r241618697
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -427,7 +427,7 @@ public void close() throws IOException {
     public void unloadNamespaceBundlesGracefully() {
         try {
             // make broker-node unavailable from the cluster
-            if (pulsar.getLoadManager() != null) {
+            if (pulsar.getLoadManager() != null && pulsar.getLoadManager().get()
!= null) {
 
 Review comment:
   this is an unrelated change. can you remove it?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message