pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #3168: Refactor api commands
Date Thu, 13 Dec 2018 20:38:18 GMT
srkukarni commented on a change in pull request #3168: Refactor api commands
URL: https://github.com/apache/pulsar/pull/3168#discussion_r241553260
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SinkBase.java
 ##########
 @@ -183,60 +183,63 @@ public SinkStatus getSinkStatus(final @PathParam("tenant") String tenant,
             @ApiResponse(code = 403, message = "The requester doesn't have admin permissions")
     })
     @Path("/{tenant}/{namespace}")
-    public Response listSinks(final @PathParam("tenant") String tenant,
-                              final @PathParam("namespace") String namespace) {
-        return sink.listFunctions(tenant, namespace);
-
+    public void listSinks(final @PathParam("tenant") String tenant,
 
 Review comment:
   return list<string>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message