pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage
Date Thu, 13 Dec 2018 11:41:57 GMT
ivankelly commented on a change in pull request #2865: Refactored JCloud Tiered Storage
URL: https://github.com/apache/pulsar/pull/2865#discussion_r241367338
 
 

 ##########
 File path: tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/provider/TieredStorageConfiguration.java
 ##########
 @@ -47,9 +50,28 @@
     public static final String BLOB_STORE_PROVIDER_KEY = "managedLedgerOffloadDriver";
     public static final String METADATA_FIELD_BUCKET = "bucket";
     public static final String METADATA_FIELD_REGION = "region";
-    public static final String METADATA_FIELD_ENDPOINT = "endpoint";
+    public static final String METADATA_FIELD_ENDPOINT = "serviceEndpoint";
+    public static final String METADATA_FIELD_MAX_BLOCK_SIZE = "maxBlockSizeInBytes";
+    public static final String METADATA_FIELD_READ_BUFFER_SIZE = "readBufferSizeInBytes";
+
     protected static final int MB = 1024 * 1024;
 
+    /*
+     * Previous property names, for backwards-compatibility.
+     */
+    static final String BC_S3_REGION = "s3ManagedLedgerOffloadRegion";
 
 Review comment:
   These probably belong in the test file rather than here, since you are constructing the
key from scratch below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message