pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #3166: Sources/Sinks can be launched using fat jars as well
Date Wed, 12 Dec 2018 23:09:56 GMT
srkukarni commented on a change in pull request #3166: Sources/Sinks can be launched using
fat jars as well
URL: https://github.com/apache/pulsar/pull/3166#discussion_r241219372
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/LocalRunner.java
 ##########
 @@ -120,39 +120,35 @@ void start() throws Exception {
             if (builtInSource != null) {
                 sourceConfig.setArchive(builtInSource);
             }
-            NarClassLoader classLoader;
 
 Review comment:
   Built-ins should be passed to the localrun with a proper file location, so they can be

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message