pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3158: improve avro schema deserialization by reusing binary decoder
Date Mon, 10 Dec 2018 23:52:35 GMT
merlimat commented on a change in pull request #3158: improve avro schema deserialization by
reusing binary decoder
URL: https://github.com/apache/pulsar/pull/3158#discussion_r240426990
 
 

 ##########
 File path: pulsar-client-schema/src/main/java/org/apache/pulsar/client/impl/schema/AvroSchema.java
 ##########
 @@ -45,6 +47,9 @@
     private BinaryEncoder encoder;
     private ByteArrayOutputStream byteArrayOutputStream;
 
+    public static final FastThreadLocal<BinaryDecoder> decoders =
 
 Review comment:
   `private` ? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message