pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition implicitly when messageRouter is set
Date Fri, 07 Dec 2018 09:32:06 GMT
erenavsarogullari commented on a change in pull request #3126: [Message Routing] Set CustomPartition
implicitly when messageRouter is set
URL: https://github.com/apache/pulsar/pull/3126#discussion_r239743364
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
 ##########
 @@ -102,6 +101,11 @@ private ProducerBuilderImpl(PulsarClientImpl client, ProducerConfigurationData
c
                     .failedFuture(new IllegalArgumentException("Topic name must be set on
the producer builder"));
         }
 
+        if(conf.getCustomMessageRouter() != null
+                && conf.getMessageRoutingMode() != MessageRoutingMode.CustomPartition)
{
 
 Review comment:
   Yep, exactly. I was thinking the same approach without breaking `messageRoutingMode`' s
**optional** behaviour.
   So, We can move this logic to final stage (`createAsync`) by removing default setting (`messageRoutingMode=null`).
   I think all of us are on the same page so will be addressing in this direction. Thanks
all again ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message