pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jai1 edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and TimePartitioned
Date Tue, 04 Dec 2018 22:31:16 GMT
jai1 edited a comment on issue #3118: UnAcked message tracker based on HashedWheelTimer and
TimePartitioned
URL: https://github.com/apache/pulsar/pull/3118#issuecomment-444284382
 
 
   I would suggest to modify UnAckedMessageTracker instead of creating a new class.
   
   - Change ConsumerConfig => `setAckTimeout(time, timeunit, numOfSlots); // assert (numOfSlots
>= 2);`
   - In UnAckedMessageTracker 
   1.  Currently there are only two slots instead use List<HashSet<MessageId>>
of size  numOfSlots. 
   2. Divide newAckTimeout = ackTimeout/(numOfSlots - 1); 
   3. add new messages to `list.get(0)`
   4. On acktimeout redeliver `list.get(list.size() - 1)`;

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message