pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ConcurrencyPractitioner commented on a change in pull request #3108: Exception Handling for Null Pointer Exception in BrokerService
Date Mon, 03 Dec 2018 23:49:14 GMT
ConcurrencyPractitioner commented on a change in pull request #3108: Exception Handling for
Null Pointer Exception in BrokerService
URL: https://github.com/apache/pulsar/pull/3108#discussion_r238483572
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -429,7 +429,11 @@ public void unloadNamespaceBundlesGracefully() {
             // make broker-node unavailable from the cluster
             if (pulsar.getLoadManager() != null) {
                 try {
-                    pulsar.getLoadManager().get().disableBroker();
+                    if (pulsar.getLoadManager() == null || pulsar.getLoadManager().get()
== null) {
 
 Review comment:
   No problem with that. It simplifies things.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message