From commits-return-18228-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Tue Nov 27 15:21:44 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6E66A180677 for ; Tue, 27 Nov 2018 15:21:44 +0100 (CET) Received: (qmail 69833 invoked by uid 500); 27 Nov 2018 14:21:43 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 69824 invoked by uid 99); 27 Nov 2018 14:21:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Nov 2018 14:21:43 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] maskit commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication Message-ID: <154332850300.25298.7863619911226224375.gitbox@gitbox.apache.org> Date: Tue, 27 Nov 2018 14:21:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit maskit commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication URL: https://github.com/apache/pulsar/pull/3067#discussion_r236682844 ########## File path: pulsar-client-cpp/lib/auth/AuthToken.cc ########## @@ -0,0 +1,116 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include "AuthToken.h" + +#include +#include + +#include + +namespace pulsar { + +// AuthDataToken + +AuthDataToken::AuthDataToken(const TokenSupplier &tokenSupplier) { tokenSupplier_ = tokenSupplier; } Review comment: I use initializer list whenever it's possible. https://www.geeksforgeeks.org/when-do-we-use-initializer-list-in-c/ btw, is it for security that this class doesn't have an actual token as a member? (to not keep a raw token on memory long time?) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services