From commits-return-17612-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Nov 16 22:54:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 95EFA1807A3 for ; Fri, 16 Nov 2018 22:54:06 +0100 (CET) Received: (qmail 84139 invoked by uid 500); 16 Nov 2018 21:54:05 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 84110 invoked by uid 99); 16 Nov 2018 21:54:05 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Nov 2018 21:54:05 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] sijie commented on a change in pull request #2998: support mysql binlog sync to pulsar by canal Message-ID: <154240524514.19532.7732907186630448530.gitbox@gitbox.apache.org> Date: Fri, 16 Nov 2018 21:54:05 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sijie commented on a change in pull request #2998: support mysql binlog sync to pulsar by canal URL: https://github.com/apache/pulsar/pull/2998#discussion_r234359153 ########## File path: pulsar-io/pom.xml ########## @@ -45,6 +45,7 @@ elastic-search kafka-connect-adaptor debezium + canal Review comment: nit: fix the indent here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services