From commits-return-16943-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Nov 2 02:26:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 21403180677 for ; Fri, 2 Nov 2018 02:26:07 +0100 (CET) Received: (qmail 5318 invoked by uid 500); 2 Nov 2018 01:26:06 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 5309 invoked by uid 99); 2 Nov 2018 01:26:06 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 01:26:06 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] rdhabalia opened a new pull request #2911: Fix pulsar function-metrics artifacts deploy Message-ID: <154112196634.7739.14977436015930459910.gitbox@gitbox.apache.org> Date: Fri, 02 Nov 2018 01:26:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit rdhabalia opened a new pull request #2911: Fix pulsar function-metrics artifacts deploy URL: https://github.com/apache/pulsar/pull/2911 ### Motivation Right now, maven deploys shaded jar of `pulsar-function-metrics` and broker distribution uses shaded `pulsar-function-metrics` because of that `pulsar-function-metrics` classes are having conflict with other jars in the classpath. Ideally, broker should never depend on any shaded pulsar artifacts unless it requires to avoid any unexpected shading change into dependent artifacts. eg: below stacktrace shows how broker loads all classes from `pulsar-function-metrics` ``` at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292) ~[?:1.8.0_131] at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308) ~[?:1.8.0_131] at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:593) ~[?:1.8.0_131] at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:614) ~[?:1.8.0_131] at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:1983) ~[?:1.8.0_131] at org.apache.pulsar.broker.service.BrokerService.getOrCreateTopic(BrokerService.java:457) ~[pulsar-broker-2.2.2-yahoo.jar:2.2.2-yahoo] at org.apache.pulsar.broker.service.ServerCnx.lambda$18(ServerCnx.java:591) ~[pulsar-broker-2.2.2-yahoo.jar:2.2.2-yahoo] at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602) ~[?:1.8.0_131] at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:614) ~[?:1.8.0_131] at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:1983) ~[?:1.8.0_131] at org.apache.pulsar.broker.service.ServerCnx.lambda$6(ServerCnx.java:550) ~[pulsar-broker-2.2.2-yahoo.jar:2.2.2-yahoo] at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:602) [?:1.8.0_131] at java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:614) [?:1.8.0_131] at java.util.concurrent.CompletableFuture.thenApply(CompletableFuture.java:1983) [?:1.8.0_131] at org.apache.pulsar.broker.service.ServerCnx.handleSubscribe(ServerCnx.java:539) [pulsar-broker-2.2.2-yahoo.jar:2.2.2-yahoo] at org.apache.pulsar.common.api.PulsarDecoder.channelRead(PulsarDecoder.java:202) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:310) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:284) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:340) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1414) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:362) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:348) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:945) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.epoll.AbstractEpollStreamChannel$EpollStreamUnsafe.epollInReady(AbstractEpollStreamChannel.java:806) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.epoll.EpollEventLoop.processReady(EpollEventLoop.java:404) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:304) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:886) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) [pulsar-functions-metrics-2.2.2-yahoo.jar:?] ``` ### Modifications with this change maven can deploy all original and shaded artifacts to the maven repo and broker will only fetch original artifact of pulsar-function-metrics. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services