pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication
Date Wed, 28 Nov 2018 19:15:56 GMT
merlimat commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation
for token authentication
URL: https://github.com/apache/pulsar/pull/3067#discussion_r237223642
 
 

 ##########
 File path: pulsar-client-cpp/tests/CMakeLists.txt
 ##########
 @@ -25,4 +25,4 @@ add_executable(main ${TEST_SOURCES})
 
 target_include_directories(main PRIVATE ${CMAKE_SOURCE_DIR}/lib)
 
-target_link_libraries(main ${CLIENT_LIBS} ${GMOCK_LIBRARY_PATH})
+target_link_libraries(main ${CLIENT_LIBS} pulsarShared ${GMOCK_LIBRARY_PATH})
 
 Review comment:
   Yes, this is slightly unrelated, moving to its own PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message