pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication
Date Tue, 27 Nov 2018 11:20:03 GMT
ivankelly commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation
for token authentication
URL: https://github.com/apache/pulsar/pull/3067#discussion_r236619588
 
 

 ##########
 File path: pulsar-client-go/pulsar/c_client.go
 ##########
 @@ -127,6 +127,37 @@ func newAuthenticationTLS(certificatePath string, privateKeyPath string)
Authent
 	return auth
 
 Review comment:
   I haven't reviewed this, don't know go.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message