pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] ivankelly commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation for token authentication
Date Tue, 27 Nov 2018 11:20:03 GMT
ivankelly commented on a change in pull request #3067: PIP-25: C++ / Python / Go implementation
for token authentication
URL: https://github.com/apache/pulsar/pull/3067#discussion_r236613205
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar_test.py
 ##########
 @@ -793,6 +793,43 @@ def test_get_topics_partitions(self):
                          [topic_non_partitioned])
         client.close()
 
+    def test_token_auth(self):
+        with open('/tmp/pulsar-test-data/certs/token.txt') as tf:
+            token = tf.read().strip()
+        client = Client(self.adminUrl,
 
 Review comment:
   adminUrl is a http endpoint? maybe add a comment that this is testing both http and binary
endpoints

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message