pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2888: PIP-25: Token based authentication
Date Tue, 27 Nov 2018 07:27:05 GMT
merlimat commented on a change in pull request #2888: PIP-25: Token based authentication
URL: https://github.com/apache/pulsar/pull/2888#discussion_r236544887
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/auth/AuthenticationTls.java
 ##########
 @@ -41,6 +41,14 @@
     private String certFilePath;
     private String keyFilePath;
 
+    public AuthenticationTls() {
 
 Review comment:
   This is related to a small refactoring that I did to add a couple of methods in `AuthenticationFactory`
to create auth instance without having to know the full implementation class name.
   
   Added: 
   ```java
   AuthenticationFactory.token("xxxxx");
   AuthenticationFactory.token(() -> "xxxx"); // With custom supplier
   
   // Added for consistency
   AuthenticationFactory.TLS("/my-cert.pem", "/my-key.pem"); 
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message