pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #3061: [conf] keep bookkeeper.conf insync with 4.7.2 bookkeeper's conf template
Date Mon, 26 Nov 2018 20:48:06 GMT
merlimat commented on a change in pull request #3061: [conf] keep bookkeeper.conf insync with
4.7.2 bookkeeper's conf template
URL: https://github.com/apache/pulsar/pull/3061#discussion_r236420206
 
 

 ##########
 File path: conf/bookkeeper.conf
 ##########
 @@ -495,35 +480,34 @@ compactionRateByEntries=1000
 # Set the rate at which compaction will readd entries. The unit is bytes added per second.
 compactionRateByBytes=1000000
 
-#############################################################################
-## Statistics
-#############################################################################
-
-# Whether statistics are enabled
-# enableStatistics=true
-
-# Stats Provider Class (if statistics are enabled)
-statsProviderClass=org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
-
-# Default port for Prometheus metrics exporter
-prometheusStatsHttpPort=8000
+# Flag to enable/disable transactional compaction. If it is set to true, it will use transactional
compaction,
+# which it will use new entry log files to store compacted entries during compaction; if
it is set to false,
+# it will use normal compaction, which it shares same entry log file with normal add operations.
+# useTransactionalCompaction=false
 
 Review comment:
   Since the python script to replace values in the file is only changing in uncommented lines,
can we uncomment all the lines and leave the default values?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message