pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2994: cleaning up and improving function metrics
Date Fri, 16 Nov 2018 01:05:08 GMT
jerrypeng commented on a change in pull request #2994:  cleaning up and improving function
metrics
URL: https://github.com/apache/pulsar/pull/2994#discussion_r234062046
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
 ##########
 @@ -537,6 +454,223 @@ private void stopFunction(String fullyQualifiedInstanceId, boolean
restart) thro
         }
     }
 
+    /**
 
 Review comment:
   Can't really combine those two function since getFunctionInstanceStats returns the stats
for instance with getFunctionStats returns stats overall and for all instances.  Different
objects are returned.  What can be refactored / combined is the logic between the get stats
functions and get status functions.  I didn't want to refactor the logic there since there
are already many changes in this PR as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message