pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] srkukarni commented on a change in pull request #2994: cleaning up and improving function metrics
Date Fri, 16 Nov 2018 00:42:26 GMT
srkukarni commented on a change in pull request #2994:  cleaning up and improving function
metrics
URL: https://github.com/apache/pulsar/pull/2994#discussion_r234058511
 
 

 ##########
 File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionRuntimeManager.java
 ##########
 @@ -537,6 +454,223 @@ private void stopFunction(String fullyQualifiedInstanceId, boolean
restart) thro
         }
     }
 
+    /**
 
 Review comment:
   For all new functionality, could we collapse getInstanceStats and getFunctionStats into
one implementation? I see a lot of duplicate code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message