pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2983: add replication_delay to namespace metrics
Date Tue, 13 Nov 2018 23:35:34 GMT
merlimat commented on a change in pull request #2983: add replication_delay to namespace metrics
URL: https://github.com/apache/pulsar/pull/2983#discussion_r233264597
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/NamespaceStats.java
 ##########
 @@ -72,6 +74,7 @@ public Metrics add(String namespace) {
         dMetrics.put("brk_no_of_consumers", consumerCount);
         dMetrics.put("brk_msg_backlog", msgBacklog);
         dMetrics.put("brk_replication_backlog", msgReplBacklog);
+        dMetrics.put("brk_replication_delay_second", msgReplDelayInSeconds);
 
 Review comment:
   Should it be made explicit this is the max value? That would help people building aggregations
in dashboard as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message