pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2957: Add Connect and Read timeout to pulsar admin
Date Mon, 12 Nov 2018 22:52:03 GMT
merlimat commented on a change in pull request #2957: Add Connect and Read timeout to pulsar
admin
URL: https://github.com/apache/pulsar/pull/2957#discussion_r232839886
 
 

 ##########
 File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImpl.java
 ##########
 @@ -93,4 +93,16 @@ public PulsarAdminBuilder enableTlsHostnameVerification(boolean enableTlsHostnam
         conf.setTlsHostnameVerificationEnable(enableTlsHostnameVerification);
         return this;
     }
+
+    @Override
+    public PulsarAdminBuilder setConnectionTimeOutSeconds(int connectionTimeOutSeconds) {
+        conf.setConnectTimeOutSeconds(connectionTimeOutSeconds);
 
 Review comment:
   Instead of adding field in `ClientConfigurationData` that are only used for the admin client
we can just add them in `PulsarAdminBuilderImpl`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message