pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2957: Add Connect and Read timeout to pulsar admin
Date Sat, 10 Nov 2018 06:37:57 GMT
merlimat commented on a change in pull request #2957: Add Connect and Read timeout to pulsar
admin
URL: https://github.com/apache/pulsar/pull/2957#discussion_r232443830
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
 ##########
 @@ -58,6 +58,9 @@
     private int maxLookupRequest = 50000;
     private int maxNumberOfRejectedRequestPerConnection = 50;
     private int keepAliveIntervalSeconds = 30;
+
+    private long connectTimeOutSeconds = 60;
 
 Review comment:
   Why add these to `ClientConfigurationData` when they're only relevant to admin client?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message