pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie closed pull request #2941: Handle case where function produces some output but no output topic given
Date Tue, 06 Nov 2018 08:27:25 GMT
sijie closed pull request #2941: Handle case where function produces some output but no output
topic given
URL: https://github.com/apache/pulsar/pull/2941
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-functions/instance/src/main/python/python_instance.py b/pulsar-functions/instance/src/main/python/python_instance.py
index 6f74461e85..66d222c73c 100644
--- a/pulsar-functions/instance/src/main/python/python_instance.py
+++ b/pulsar-functions/instance/src/main/python/python_instance.py
@@ -272,7 +272,8 @@ def done_producing(self, consumer, orig_message, result, sent_message):
       consumer.acknowledge(orig_message)
 
   def process_result(self, output, msg):
-    if output is not None:
+    if output is not None and self.instance_config.function_details.sink.topic != None and
\
+            len(self.instance_config.function_details.sink.topic) > 0:
       if self.output_serde is None:
         self.setup_output_serde()
       if self.producer is None:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message