pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function instance
Date Mon, 05 Nov 2018 19:13:56 GMT
jerrypeng commented on a change in pull request #2930: Expose metrics via http port in function
instance
URL: https://github.com/apache/pulsar/pull/2930#discussion_r230875950
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
 ##########
 @@ -195,12 +213,13 @@ public void run() {
             }
         });
 
-        // registering jvm metrics to prometheus
-        DefaultExports.initialize();
-
         log.info("Starting runtimeSpawner");
         runtimeSpawner.start();
 
+        // starting metrics server
+        log.info("Starting metrics server on port {}", metrics_port);
 
 Review comment:
   Are you saying we should have some sort of flag to determine whether we should run the
http server for metrics?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message