pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2914: Beginging to refactor function metrics to use prometheus
Date Sat, 03 Nov 2018 06:54:20 GMT
merlimat commented on a change in pull request #2914: Beginging to refactor function metrics
to use prometheus
URL: https://github.com/apache/pulsar/pull/2914#discussion_r230546982
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java
 ##########
 @@ -186,6 +188,10 @@ public void run() {
                 }
             }
         });
+
+        // registering jvm metrics to prometheus
+        DefaultExports.initialize();
 
 Review comment:
   This we need to be careful if we're running in thread mode, since it will register multiple
times and throw exception. I'd avoid this for thread-based (or process based for that matter)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message