pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie commented on a change in pull request #2906: [bookkeeper] bump bookkepeer version to 4.9.0
Date Thu, 01 Nov 2018 23:35:16 GMT
sijie commented on a change in pull request #2906: [bookkeeper] bump bookkepeer version to
4.9.0
URL: https://github.com/apache/pulsar/pull/2906#discussion_r230233343
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -141,7 +141,7 @@ flexible messaging model and an intuitive client API.</description>
     <!-- apache commons -->
     <commons-compress.version>1.15</commons-compress.version>
 
-    <bookkeeper.version>4.7.2</bookkeeper.version>
+    <bookkeeper.version>4.9.0-20181031-b17b165-SNAPSHOT</bookkeeper.version>
 
 Review comment:
   >  I had the concern that SNAPSHOT version gets removed after sometime and it's temporary
so, pulsar pipeline might fail at that time. 
   
   I am not sure I understand this. why pipeline will fail, if the version is pinned to a
gitsha.
   
   > also, SNAPSHOT might not be considered as stable version right? 
   
   sure. but master in pulsar is also "snapshot", no? the point is for pulsar to take bk's
version as early as possible, so that when bk and pulsar are released, they are all tested
together for a long time. since 2.2.0 is just released, we have time for 2.3.0 to be released.
why not try to bump bk version in the early stage of 2.3.0, rather than late in the 2.3.0
release cycle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message