From commits-return-16500-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Oct 26 11:02:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8255A180675 for ; Fri, 26 Oct 2018 11:02:57 +0200 (CEST) Received: (qmail 33555 invoked by uid 500); 26 Oct 2018 09:02:56 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 33546 invoked by uid 99); 26 Oct 2018 09:02:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Oct 2018 09:02:56 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics Message-ID: <154054457606.15466.13292788589045276117.gitbox@gitbox.apache.org> Date: Fri, 26 Oct 2018 09:02:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics URL: https://github.com/apache/pulsar/pull/2829#discussion_r228454245 ########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java ########## @@ -31,7 +31,7 @@ private final String topicName; private final MessageId messageId; - TopicMessageIdImpl(String topicPartitionName, String topicName, MessageId messageId) { + public TopicMessageIdImpl(String topicPartitionName, String topicName, MessageId messageId) { Review comment: Is this public still needed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services