From commits-return-16465-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Oct 25 21:46:44 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1949D180675 for ; Thu, 25 Oct 2018 21:46:43 +0200 (CEST) Received: (qmail 7688 invoked by uid 500); 25 Oct 2018 19:46:43 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 7669 invoked by uid 99); 25 Oct 2018 19:46:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Oct 2018 19:46:43 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] srkukarni commented on a change in pull request #2848: Make IdentitySerde handle bytes as well Message-ID: <154049680264.14623.6854435136626849062.gitbox@gitbox.apache.org> Date: Thu, 25 Oct 2018 19:46:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit srkukarni commented on a change in pull request #2848: Make IdentitySerde handle bytes as well URL: https://github.com/apache/pulsar/pull/2848#discussion_r228310470 ########## File path: pulsar-client-cpp/python/pulsar/functions/serde.py ########## @@ -75,6 +75,8 @@ def __init__(self): def serialize(self, input): if type(input) in self._types: return str(input).encode('utf-8') + if type(input) == bytes: + return input raise TypeError Review comment: Added ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services