From commits-return-16357-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Wed Oct 24 01:58:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6331B180675 for ; Wed, 24 Oct 2018 01:58:21 +0200 (CEST) Received: (qmail 77652 invoked by uid 500); 23 Oct 2018 23:58:20 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 77643 invoked by uid 99); 23 Oct 2018 23:58:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Oct 2018 23:58:20 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface Message-ID: <154033910002.13729.16382867270916364182.gitbox@gitbox.apache.org> Date: Tue, 23 Oct 2018 23:58:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cckellogg commented on a change in pull request #2826: Secrets Interface URL: https://github.com/apache/pulsar/pull/2826#discussion_r227603808 ########## File path: pulsar-common/src/main/java/org/apache/pulsar/common/io/SinkConfig.java ########## @@ -55,6 +55,7 @@ private Map inputSpecs = new TreeMap<>(); private Map configs; + private Map secrets; Review comment: +1 for additional key=values for secrets so Map or Map> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services