From commits-return-16188-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Thu Oct 18 20:01:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 090FD18064E for ; Thu, 18 Oct 2018 20:01:09 +0200 (CEST) Received: (qmail 68410 invoked by uid 500); 18 Oct 2018 18:01:09 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 68393 invoked by uid 99); 18 Oct 2018 18:01:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Oct 2018 18:01:09 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] jerrypeng commented on a change in pull request #2807: Source/Sink Endpoint validations Message-ID: <153988566854.31572.4222415981407231566.gitbox@gitbox.apache.org> Date: Thu, 18 Oct 2018 18:01:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jerrypeng commented on a change in pull request #2807: Source/Sink Endpoint validations URL: https://github.com/apache/pulsar/pull/2807#discussion_r226407986 ########## File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/FunctionsImpl.java ########## @@ -288,43 +293,57 @@ public Response updateFunction(final String tenant, final String namespace, fina } public Response deregisterFunction(final String tenant, final String namespace, final String functionName, - String clientRole) { + String sourceName, String sinkName, String clientRole) { Review comment: ok I guess that is fine for right now. I am concerned here since the code logic is complex and bugs can be easily introduced (especially by developers that didn't originally work on this) that will break all three. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services