From commits-return-15709-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Fri Oct 5 18:34:59 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 33778180677 for ; Fri, 5 Oct 2018 18:34:59 +0200 (CEST) Received: (qmail 99607 invoked by uid 500); 5 Oct 2018 16:34:58 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 99597 invoked by uid 99); 5 Oct 2018 16:34:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Oct 2018 16:34:58 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] merlimat commented on a change in pull request #2730: [schema] provide a flag to disable/enable schema validation on broker and change default bytes producer to use `AUTO_PRODUCE_BYTES` Message-ID: <153875729778.12723.18312894067578699065.gitbox@gitbox.apache.org> Date: Fri, 05 Oct 2018 16:34:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit merlimat commented on a change in pull request #2730: [schema] provide a flag to disable/enable schema validation on broker and change default bytes producer to use `AUTO_PRODUCE_BYTES` URL: https://github.com/apache/pulsar/pull/2730#discussion_r223068545 ########## File path: conf/broker.conf ########## @@ -517,6 +517,13 @@ exposePublisherStats=true # The schema storage implementation used by this broker schemaRegistryStorageClassName=org.apache.pulsar.broker.service.schema.BookkeeperSchemaStorageFactory +# Enforce schema validation on following cases: +# +# - if a producer without a schema attempts to produce to a topic with schema, the producer will be +# failed to connect. PLEASE be carefully on using this, since non-java clients don't support schema. +# if you enable this setting, it will cause non-java clients failed to produce. +isSchemaValidationEnforced=false Review comment: 👍 For 2.2 this flag is already enough. Later we should add namespace level control ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services