From commits-return-15478-archive-asf-public=cust-asf.ponee.io@pulsar.apache.org Tue Oct 2 23:07:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6A6A5180638 for ; Tue, 2 Oct 2018 23:07:50 +0200 (CEST) Received: (qmail 80536 invoked by uid 500); 2 Oct 2018 21:07:49 -0000 Mailing-List: contact commits-help@pulsar.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pulsar.apache.org Delivered-To: mailing list commits@pulsar.apache.org Received: (qmail 80527 invoked by uid 99); 2 Oct 2018 21:07:49 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 21:07:49 +0000 From: GitBox To: commits@pulsar.apache.org Subject: [GitHub] jerrypeng commented on a change in pull request #2698: Rework functions api with consumer Message-ID: <153851446890.1877.12366392524746945650.gitbox@gitbox.apache.org> Date: Tue, 02 Oct 2018 21:07:48 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jerrypeng commented on a change in pull request #2698: Rework functions api with consumer URL: https://github.com/apache/pulsar/pull/2698#discussion_r222112490 ########## File path: pulsar-functions/api-java/src/main/java/org/apache/pulsar/functions/api/Consumer.java ########## @@ -0,0 +1,35 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.functions.api; + +/** + * This is one of the core interface of the function api. The process is called + * for every message of the input topic of the function. The incoming input bytes + * are converted to the input type I for simple Java types(String, Integer, Boolean, + * Map, and List types) and for org.Json type. If this serialization approach does not + * meet your needs, you can use the byte stream handler defined in RawRequestHandler. + */ +@FunctionalInterface +public interface Consumer { Review comment: I rather the function runtime not have to worry about another interface ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services