pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] sijie closed pull request #2878: Fix helm lint error for zookeeper-metadata.yaml
Date Mon, 29 Oct 2018 20:00:08 GMT
sijie closed pull request #2878: Fix helm lint error for zookeeper-metadata.yaml
URL: https://github.com/apache/pulsar/pull/2878
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/deployment/kubernetes/helm/pulsar/templates/zookeeper-metadata.yaml b/deployment/kubernetes/helm/pulsar/templates/zookeeper-metadata.yaml
index bb25f46767..5115286087 100644
--- a/deployment/kubernetes/helm/pulsar/templates/zookeeper-metadata.yaml
+++ b/deployment/kubernetes/helm/pulsar/templates/zookeeper-metadata.yaml
@@ -46,9 +46,9 @@ spec:
       - name: "{{ template "pulsar.fullname" . }}-{{ .Values.zookeeperMetadata.component
}}"
         image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
         imagePullPolicy: {{ .Values.image.pullPolicy }}
-      {{- if .Values.zookeeper_metadata.resources }}
+      {{- if .Values.zookeeperMetadata.resources }}
         resources:
-{{ toYaml .Values.zookeeper_metadata.resources | indent 10 }}
+{{ toYaml .Values.zookeeperMetadata.resources | indent 10 }}
       {{- end }}
         command: ["sh", "-c"]
         args:
diff --git a/deployment/kubernetes/helm/pulsar/values.yaml b/deployment/kubernetes/helm/pulsar/values.yaml
index edbb973299..fe237e8ae2 100644
--- a/deployment/kubernetes/helm/pulsar/values.yaml
+++ b/deployment/kubernetes/helm/pulsar/values.yaml
@@ -256,6 +256,7 @@ proxy:
   ##
   service:
     annotations: {}
+    type: NodePort
     ports:
     - name: http
       port: 8080


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message