pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned Topics
Date Fri, 26 Oct 2018 09:02:56 GMT
maskit commented on a change in pull request #2829: Fix Websocket Consume Messages in Partitioned
Topics
URL: https://github.com/apache/pulsar/pull/2829#discussion_r228454245
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/TopicMessageIdImpl.java
 ##########
 @@ -31,7 +31,7 @@
     private final String topicName;
     private final MessageId messageId;
 
-    TopicMessageIdImpl(String topicPartitionName, String topicName, MessageId messageId)
{
+    public TopicMessageIdImpl(String topicPartitionName, String topicName, MessageId messageId)
{
 
 Review comment:
   Is this public still needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message