pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] massakam commented on a change in pull request #2845: Make proxy advertise protocol version of client to broker
Date Fri, 26 Oct 2018 01:32:36 GMT
massakam commented on a change in pull request #2845: Make proxy advertise protocol version
of client to broker
URL: https://github.com/apache/pulsar/pull/2845#discussion_r228383732
 
 

 ##########
 File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java
 ##########
 @@ -218,7 +223,7 @@ protected void handleConnected(CommandConnected connected) {
 
             state = BackendState.HandshakeCompleted;
 
-            inboundChannel.writeAndFlush(Commands.newConnected(connected.getProtocolVersion())).addListener(future
-> {
+            inboundChannel.writeAndFlush(Commands.newConnected(protocolVersion)).addListener(future
-> {
 
 Review comment:
   Thank you @merlimat, I reverted it back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message