pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] merlimat commented on a change in pull request #2831: Adding option to use TLS in broker admin client.
Date Wed, 24 Oct 2018 16:29:39 GMT
merlimat commented on a change in pull request #2831: Adding option to use TLS in broker admin
client.
URL: https://github.com/apache/pulsar/pull/2831#discussion_r227860753
 
 

 ##########
 File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
 ##########
 @@ -452,7 +452,7 @@
     // Replicator producer queue size;
     private int replicationProducerQueueSize = 1000;
     // Enable TLS when talking with other clusters to replicate messages
-    private boolean replicationTlsEnabled = false;
+    private boolean brokerClientTlsEnabled = false;
 
 Review comment:
   We cannot just remove the old config key or we'd break compatibility. 
   
   We need to keep it and mark it as `@Deprecated`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message