pulsar-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] cckellogg commented on a change in pull request #2826: Secrets Interface
Date Tue, 23 Oct 2018 23:55:08 GMT
cckellogg commented on a change in pull request #2826: Secrets Interface
URL: https://github.com/apache/pulsar/pull/2826#discussion_r227603533
 
 

 ##########
 File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdSinks.java
 ##########
 @@ -406,6 +408,12 @@ void processArguments() throws Exception {
                 sinkConfig.setConfigs(parseConfigs(sinkConfigString));
             }
 
+            if (null != secretsConfig) {
 
 Review comment:
   to start maybe secrets can only be defined in the function config or user config. secrets
might need more than just a single key=value

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message